Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally render pipeline modals #3300

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conditionally render pipeline modals #3300

merged 1 commit into from
Oct 4, 2024

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Oct 4, 2024 •
edited
Loading

Towards RHOAIENG-12117

Description

Update usage of pipeline Archive, Restore, and View server modals to render them only when they would be shown rather than having them be rendered but hidden.

How Has This Been Tested?

Run thru the UI and check that then modals are shown only when they should be shown.

  • From a project details page
    • select the Pipelines tab
    • expand a pipeline that has pipeline versions
    • select a pipeline version
    • from the pipelines page, select the Pipeline server actions menu and choose View pipeline server configuration
    • verify the View pipeline server modal is shown
  • From a project details page
    • select the Pipelines tab
    • expand a pipeline that has pipeline versions
    • from a pipeline version, use the kebab and select View runs
    • from the pipeline rus page, select the Actions menu and choose Archive
    • verify the Archiving run modal is shown
  • Select the Experiments nav item, then Experiments and Runs
    • for an experiment, select the kebab menu and select Archive
    • verify the Archiving experiment? modal is shown.
  • Select the Experiments nav item, then Experiments and Runs
    • select the Archive tab
    • for an experiment, select the kebab menu and select Restore
    • verify the Restore experiment? modal is shown.
  • Select the Data Science Pipelines nav item
    • for a project without a configured pipeline server, select the Configure pipeline server button
    • verify the Configure pipeline server modal is shown.
  • Select the Data Science Pipelines nav item
    • for a project with a configured pipeline server, select the Import pipeline button
    • verify the Import pipeline modal is shown.
  • Select the Experiments nav item, then Experiments and Runs
    • select the Create experiment button
    • verify the Create experiment modal is shown.

Test Impact

Current tests already test these modals.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

@jeff-phillips-18 jeff-phillips-18 changed the title Conditionally render pipeline Archive, Restore, and View server modals Conditionally render pipeline modals Oct 4, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.13793% with 15 lines in your changes missing coverage. Please review.

Project coverage is 84.78%. Comparing base (3e5d40f) to head (4c93915).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ines/content/experiment/CreateExperimentButton.tsx 12.50% 7 Missing ⚠️
.../pipelines/content/import/ImportPipelineButton.tsx 12.50% 7 Missing ⚠️
...lines/content/import/ImportPipelineSplitButton.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3300      +/-   ##
==========================================
- Coverage   84.84%   84.78%   -0.07%     
==========================================
  Files        1308     1308              
  Lines       29225    29230       +5     
  Branches     7893     7914      +21     
==========================================
- Hits        24797    24782      -15     
- Misses       4428     4448      +20
Files with missing lines Coverage Δ
...nd/src/concepts/pipelines/content/ArchiveModal.tsx 87.50% <ø> (-0.38%) ⬇️
...ncepts/pipelines/content/PipelineServerActions.tsx 85.36% <100.00%> (ø)
...nd/src/concepts/pipelines/content/RestoreModal.tsx 86.36% <ø> (-0.60%) ⬇️
...epts/pipelines/content/ViewPipelineServerModal.tsx 88.88% <ø> (-0.40%) ⬇️
...ePipelinesServer/ConfigurePipelinesServerModal.tsx 76.08% <100.00%> (-1.92%) ⬇️
...lines/content/experiment/CreateExperimentModal.tsx 3.70% <100.00%> (-48.15%) ⬇️
...s/pipelines/content/import/PipelineImportModal.tsx 91.30% <ø> (-0.13%) ⬇️
...ipelinesDetails/pipelineRun/PipelineRunDetails.tsx 86.53% <100.00%> (ø)
...ontent/tables/experiment/ActiveExperimentTable.tsx 100.00% <100.00%> (ø)
...tent/tables/experiment/ArchivedExperimentTable.tsx 88.88% <100.00%> (+0.88%) ⬆️
... and 10 more

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5d40f...4c93915. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@openshift-ci openshift-ci bot removed the lgtm label Oct 4, 2024
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1fd4f18 into opendatahub-io:main Oct 4, 2024
8 checks passed
lokeshrangineni pushed a commit to TomerFi/odh-dashboard that referenced this pull request Oct 4, 2024
@jeff-phillips-18 @lokeshrangineni
Conditionally render pipeline modals (opendatahub-io#3300)
374d975
@jeff-phillips-18 jeff-phillips-18 deleted the pipeline-context-modals branch October 4, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt Awaiting requested review from christianvogt

@Gkrumbach07 Gkrumbach07 Awaiting requested review from Gkrumbach07

@pnaik1 pnaik1 Awaiting requested review from pnaik1

Assignees

@christianvogt christianvogt

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeff-phillips-18 @christianvogt